Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows doesn't support the inline evaluation
$(find..)
and also doesn't support the find command.nyc
can handle globbing itself, as can it appears_mocha
(i.e. this command works both without and with the--
given just before the globbing), so it doesn't seem the find command is necessary.This allows
npm test
to function on Windows using PowerShell (and presumably also command prompt). For some reason the coverage report is missing data, but it misses data without this change also.Assuming this doesn't break Travis it should be good to go.
(Windows actually does execute the tests on master, because
nyc
ormocha
receives no valid parameters and so I think defaults to thetest
directory, but it exits with an error code. This fixes that, but does not fix the lack of coverage data on Windows.)