-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker #498
Docker #498
Conversation
Don't worry about attribution, I'm just happy to get this in, haha |
Looks like you've got yourself a merge conflict! |
Fixed, and updated it to use Node 12! Plus I made it actually skip the deploy phase on PRs (when it tests that it merges with master), instead of just on branch pushes. |
I've merged this on my fork, for testing, and had it push to https://hub.docker.com/r/throne3d/discord-irc – looks to be working! Reminder before merging: this PR requires the |
1a84ee9
to
39d4e50
Compare
This now uses the https://hub.docker.com/r/discordirc/discord-irc repository! I did a test build locally, which seemed to work fine, so now it's just to see if this works on master. |
After I accidentally pushed to this repository instead of my own, the merge PR for #421's Docker support got automatically closed. I'm also not totally sure how to preserve the old commit history, in light of these all now … being … part of the main branch's … commit history. (A simple rebase didn't seem to work.) Oops. Anyway, you should be able to see that PR for more details.
@ekmartin Sorry about the messy commit history. Does this look okay? Would you be happy to add a Docker Hub image for this, and put the credentials into Travis?