Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lint config versions for eslint 5 #500

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

Throne3d
Copy link
Collaborator

@Throne3d Throne3d commented Aug 5, 2019

Bumping eslint-config-airbnb-base fixes a deprecation warning upon lint. Bumping eslint-plugin-import seems prudent since we use imports in the codebase.

The codebase is inconsistent around operator-linebreak, so I thought it best to disable that. implicit-arrow-linebreak is largely followed, but in some places we put implicits within implicits, and in one location we have a long return in the implicit and so trying to one-line it breaks the max-len rule.

Fixes deprecation warning upon lint
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.25% when pulling 2586f88 on Throne3d:fix/eslint-config-versions into 4196726 on reactiflux:master.

@Throne3d Throne3d merged commit a719185 into reactiflux:master Aug 8, 2019
@Throne3d Throne3d deleted the fix/eslint-config-versions branch August 8, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants