-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix avatars not displaying via webhooks #511
Conversation
Avatars that were 2048x2048 would break webhooks displaying avatars, defaulting to 128x128 fixes that.
Fixed all of the relevant CI issues, the remaining ones are to be fixed by you, because they expect the old 2048x2048 size:
|
It's very strange to claim the remaining CI issues are to be fixed by us – it's low effort to fix the tests to expect the right results, and the code change you're proposing does break old expected behavior, so the remaining issues are, relevantly, yours to fix. Can you provide reproduction steps for the issue this fixes? |
@Throne3d I'm not sure why the note about the tests set you off? at the time I wasn't simply aware that the tests are hosted on this repository too and noted that the tests would need to be modified for the new case, as I assumed those are hosted on travis internal configurations in some way. I will re-test if this is still necessary as a fix and document further in the coming hours. |
@Throne3d tested it just now and the issue still persists, here are the steps to reproduce it:
I will push the test fixes shortly. |
@Throne3d submitted what looked like failing tests purely based on avatar size and now the tests pass. Edit: coveralls edited its post. |
I didn't mean to come across as being set off – your comment about the tests just came off as very strange =P Thank you for this code change! It's really strange that I couldn't find anything about this in Discord's documentation, but I'm happy to merge this as-is. I'm slightly concerned that 128px might be too small, but if anyone notices a visual change, I'm hoping to get an issue and we can look into bumping it up. |
Avatars that were 2048x2048 would break webhooks displaying avatars, defaulting to 128x128 fixes that.