Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support kinetic #90

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

feat: support kinetic #90

wants to merge 4 commits into from

Conversation

vanpho93
Copy link
Member

Signed-off-by: Brian Nguyen vanpho02@gmail.com

Resolves: #86

Testing

reaction create-project kinetic kinetic && cd kinetic && pnpm install && reaction develop

Signed-off-by: Brian Nguyen <vanpho02@gmail.com>
Signed-off-by: Brian Nguyen <vanpho02@gmail.com>
Signed-off-by: Brian Nguyen <vanpho02@gmail.com>
Signed-off-by: Brian Nguyen <vanpho02@gmail.com>
Copy link
Collaborator

@tedraykov tedraykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We should discuss how we could update Kinetic because it differs from the API. The API project entirely relies on external packages and we can easily diff them. When it comes to Kinetic, all components are part of the project's source code.
A solution I can think of is to structure the project as a monorepo and each UI module (orders, products, navigation) to be a separate package, that can be updated. The packages won't have to be published but we can leverage pnpm's workspaces https://pnpm.io/workspaces
That way we can differentiate each package against the upstream package and pull the changes accordingly.

@brent-hoover
Copy link
Collaborator

@vanpho93 Now that Kinetic is public, we can probably just resolve these conflict and merge this

Copy link
Collaborator

@brent-hoover brent-hoover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one doc change

@@ -145,6 +145,33 @@ reaction develop
```
For more information about developing the admin you can go to [Mailchimp Open Commerce Documentation](https://mailchimp.com/developer/open-commerce/)

## Adding the Kinetic
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably drop the "the" here. It's just Kinetic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add kinetic as a project you can bootstrap
3 participants