fix: add padding to cart items in order complete page #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnnnat
suggested changes
Sep 25, 2018
nnnnat
reviewed
Sep 26, 2018
There was a problem hiding this comment.
@willopez Looking at the code change I think this is fine to merge, I've been unable to test it locally because I keep running into a Cannot read property 'card' of undefined error when trying to check out. Deff a problem with my setup I'm going to restart and test again but if you want to merge I think it's good2go.
|
@nnnnat that error will occur when you don't have a stripe token, which in turn means that you might not have the stripe API keys configured in reaction + staterkit https://github.com/reactioncommerce/reaction-next-starterkit#set-up-stripe |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #334
Impact: minor
Type: bugfix
Summary
Add padding to cart items in order complete page.
Testing