Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Always use https for npm registry #365

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

focusaurus
Copy link
Contributor

Resolves #364
Impact: minor
Type: bugfix

Issue

As in #364

This issue seemed to only affect me, and only when NOT on VPN, but it was consistent within those parameters. This fix is confirmed to avoid the error for me.

Solution

Manual search/replace in yarn.lock. Probably could also blow it away and regenerate I guess.

Testing

  1. Normal CI builds should suffice to test this

@focusaurus focusaurus requested a review from aldeed October 4, 2018 19:54
@aldeed aldeed merged commit b6058fc into develop Oct 5, 2018
@aldeed aldeed deleted the fix-364-focusaurus-registry-https branch October 5, 2018 19:07
This was referenced Jan 15, 2019
@spencern spencern mentioned this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mix of http and https URLs for npm registry in yarn.lock
2 participants