Add 302 redirects to env.EXTERNAL_GRAPHQL_URL #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Shepherd <christopher@reactioncommerce.com>
focusaurus
approved these changes
Jul 2, 2019
added 2 commits
July 2, 2019 14:21
Signed-off-by: Christopher Shepherd <christopher@reactioncommerce.com>
…t temporary Signed-off-by: Christopher Shepherd <christopher@reactioncommerce.com>
The redirect is permanent and 301 is therefore correct, but browsers will cache a 301 as long as possible in the absence of a Cache-Control: header, and someday 'reaction/graphql-beta' will probably become 'reaction/graphql'. Perhaps 301 with "Cache-Control: max-age=86400" header? Or am I overthinking this? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christopher Shepherd christopher@reactioncommerce.com
Resolves #549
Impact: minor
Type: feature
Issue
Adds 302 redirects for a few paths via express.js
Solution
Added redirects at the express.js level rather than the next.js router because I don't see a downside to it, and it's easy to express in just a few lines of code.
Breaking changes
none
Testing