Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(readme): component library naming #555

Merged
merged 1 commit into from
Aug 1, 2019
Merged

docs(readme): component library naming #555

merged 1 commit into from
Aug 1, 2019

Conversation

machikoyasuda
Copy link
Contributor

@machikoyasuda machikoyasuda commented Jul 31, 2019 •
edited
Loading

Signed-off-by: Machiko Yasuda machiko@reactioncommerce.com

Impact: minor
Type: docs|core

Issue

  • Don't call it the Reaction Component Library anymore
  • Call it the Example Storefront Component Library (or Storefront Component Library for short)

Solution

  • Rename the names
  • Update 2018 to 2019

Breaking changes

No

Testing

  1. Read the docs

@machikoyasuda
docs(readme): component library naming
4e8d5e2 
Signed-off-by: Machiko Yasuda <machiko@reactioncommerce.com>
@machikoyasuda machikoyasuda requested review from rc-publisher and rymorgan and removed request for rc-publisher July 31, 2019 22:50
@machikoyasuda machikoyasuda merged commit d2492f5 into develop Aug 1, 2019
@machikoyasuda machikoyasuda deleted the machikoyasuda-patch-1 branch August 1, 2019 18:25
@kieckhafer kieckhafer mentioned this pull request Aug 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rymorgan rymorgan rymorgan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@machikoyasuda @rymorgan