Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore empty_node_modules volume #591

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Conversation

focusaurus
Copy link
Contributor

Impact: minor
Type: bugfix

Issue

I removed this volume mount in some prior work not understanding it's necessity.

Solution

Add it back with a comment justifying its existence.

Breaking changes

N/A

Testing

  1. Bring up storefront (especially on mac)
  2. Locally run yarn on your host
  3. Configure your editor to use the project-specific eslint
  4. Confirm IDE/editor based linting works OK from host OS
  5. Confirm app runs fine in docker at same time

- Add more in-depth comment for why we do this

Signed-off-by: Peter Lyons <pete@reactioncommerce.com>
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and inside the container and works fine.

@willopez willopez merged commit 541ce5e into develop Oct 2, 2019
@willopez willopez deleted the volume-node-modules branch October 2, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants