Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: handle OAUTH2_IDP_HOST_URL with no ending slash and missing shop #627

Merged
merged 4 commits into from
Dec 17, 2019
Merged

Fixes: handle OAUTH2_IDP_HOST_URL with no ending slash and missing shop #627

merged 4 commits into from
Dec 17, 2019

Conversation

aldeed
Copy link
Contributor

@aldeed aldeed commented Dec 13, 2019

Resolves #626
Impact: minor
Type: bugfix

Changes

  • When OAUTH2_IDP_HOST_URL env does not end in /, logout now works correctly.
  • Throughout the app, components have been updated to render as much as possible without needing a shop loaded. The net result is that the UI loads properly and things like login/logout work even when there is no primary shop for the environment yet.

Breaking changes

None

Testing

  • Verify that logout works when OAUTH2_IDP_HOST_URL ends with / AND when it does not.
  • Connect to an API with a fresh database that has no shops yet. Verify the UI loads and login/logout works.

@aldeed
fix: handle OAUTH2_IDP_HOST_URL with no ending slash
7465ff9 
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
@aldeed
fix: show UI when no shop
6d80109 
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
@aldeed
fix: more helpful logging of 400 errors
e72cf5b 
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
@aldeed aldeed requested a review from willopez December 13, 2019 20:36
@willopez willopez requested review from mikemurray and removed request for willopez December 17, 2019 19:09
mikemurray
mikemurray approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mikemurray mikemurray merged commit 748aa60 into release-v3.0.0 Dec 17, 2019
@mikemurray mikemurray deleted the fix-aldeed-626-logout-url branch December 17, 2019 22:21
@kieckhafer kieckhafer mentioned this pull request Dec 20, 2019
Merged
@kieckhafer kieckhafer mentioned this pull request Feb 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemurray mikemurray mikemurray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aldeed @mikemurray @willopez