Setup react-testing-library and some clean up #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Lopez <will.lopez@mailchimp.com>
Signed-off-by: Will Lopez <will.lopez@mailchimp.com>
Signed-off-by: Will Lopez <will.lopez@mailchimp.com>
Signed-off-by: Will Lopez <will.lopez@mailchimp.com>
Signed-off-by: Will Lopez <will.lopez@mailchimp.com>
Signed-off-by: Will Lopez <will.lopez@mailchimp.com>
mikemurray
requested changes
Jun 16, 2020
components/Footer/Footer.test.js
Outdated
| import Footer from "./Footer"; | ||
|
|
||
| test("Renders the footer", () => { | ||
| const { getByText } = render(<Footer />); |
There was a problem hiding this comment.
You should import screen then use screen.getByText instead. This is now the recommended way to use react-testing rather than de-structuring utils from the render func. Most of the utils you're used to using are available on screen.
import { render, screen } from "@testing-library/react";
render(<Footer />);
screen.getByText(TEXT);Signed-off-by: Will Lopez <will.lopez@mailchimp.com>
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: refactor
Issue
There were a couple of unnecessary dependencies related to testing.
Solution
Removed unnecessary dependencies and added
react-testing-libraryas the preferred testing library. Also, a sample test was adde for theFootercomponent. This is a stepping stone in the general testing direction described in #683Breaking changes
Any tests that used enzyme will no longer work.
Testing