Use CANONICAL_URL for sitemap route #690
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Janus Reith mail@janusreith.de
Resolves #689
Impact: minor
Type: bugfix
Issue
Sitemap routes currently show
undefined://
asreq.protocol
is not available in api routes.Solution
As detailed in #689, this will use
CANONICAL_URL
and pass it to the sitemap query instead of parsing the url from the incoming request.Breaking changes
None - I consider it unlikely that shops request sitemaps from a host name that differs from the one defined in
CANONICAL_URL
. If that is the case, these could adjust their sitemap api route individually.Testing
loc
field.