add package-link file to storefront #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.7) Signed-off-by: dependabot[bot] <support@github.com>
kieckhafer
force-pushed
the
add-package-link-to-storefront
branch
from
a8a2728
to
ba7e068
Compare
Signed-off-by: Erik Kieckhafer <ek@ato.la>
kieckhafer
force-pushed
the
add-package-link-to-storefront
branch
from
ba7e068
to
65c6ecd
Compare
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
|
@kieckhafer We should add the |
Signed-off-by: Erik Kieckhafer <ek@ato.la>
|
@mikemurray done. |
mikemurray
reviewed
Jan 28, 2021
| @@ -0,0 +1,23 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
I this file needs execute permissions.
|
Not sure why the push is failing. |
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Akarshit Wal <akarshit.wal@mailchimp.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: chore
Adds
package-linkandpackage-unlink, similar to we have in theapiproject, to allow for dev linking of outside npm packages.We need to update the base image to use
12.14.1-v3instead of12.14.1-v1as this version installsyalcinside the container, which is required for this linking.TESTING:
bin/package-link @reactioncommerce/components ../reaction-component-library/packagebin/package-unlink @reactioncommerce/components