Fix: Error on PDP when product is missing slug #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jrw421 <jessica.wolvington@gmail.com>
Signed-off-by: jrw421 <jessica.wolvington@gmail.com>
Signed-off-by: jrw421 <jessica.wolvington@gmail.com>
MohanNarayana
requested changes
Feb 4, 2021
Signed-off-by: jrw421 <jessica.wolvington@gmail.com>
jrw421
force-pushed
the
fix-304-jrw421-product-title
branch
from
c56d1e6
to
53d5712
Compare
…torefront into fix-304-jrw421-product-title
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #750
Impact: minor
Type: bugfix
Issue
When a product was saved without a title and published to the storefront and the customer tries to open PDP for that product, the system throws
404 Not Found error(in case of Mac) andSorry! We couldn't find what you're looking forerror (in case of Ubuntu). Related to reactioncommerce/reaction-admin#304.Solution
Only make the link to the PDP available if there is a slug present. If there is a slug, the product links to the product page as expected. Otherwise the product page does not link without a valid slug. If there's a more graceful way of avoiding this error I'm happy to chat through it!
Breaking changes
None expected.
Testing