Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/stripe sca #776

Merged
merged 11 commits into from
Oct 16, 2021
Merged

Feature/stripe sca #776

merged 11 commits into from
Oct 16, 2021

Conversation

delagroove
Copy link
Contributor

@delagroove delagroove commented Aug 4, 2021 •
edited
Loading

Impact: major
Type: feature

Issue

Stripe SCA needs to be configured by default, specially for European users.

Solution

Stripe SCA plugin is now available in the storefront

Breaking changes

none, old Stripe plugin will continue to work but it will be deprecated in 10/31/2021.

Testing

  1. Set up Stripe private key in API Environment keys (.env)
  2. Set up stripe public key in storefront environment keys
  3. set a shipment method.
  4. Activate Stripe as payment method. version 1.0.0 of the plugin will say stripe, subsequent version will say Stripe (SCA) to avoid confusion with old plugin.
  5. go to step 3 of checkout.
  6. watch new Stripe form appear (or both options in a radio selection) and the selected on in a form.

janus-reith and others added 5 commits June 17, 2021 18:55
@janus-reith
feat: Add Stripe Payments Intents API SCA-compliant Payment Component
30fa912 
Signed-off-by: Janus Reith <mail@janusreith.de>
@delagroove
Merge pull request #770 from janus-reith/add-stripe-sca
d10380f 
WIP: Add Stripe Payments Intents API SCA-compliant Payment Component (Not intended for merge to trunk )
@delagroove
fix: lint errors in StripeCard, add stripe js lib
e0140f1 
Signed-off-by: Alvaro Bueno <alvaro.bueno@mailchimp.com>
@delagroove
fix: lint errors in StripeCard, add stripe js lib
4d9569d 
Signed-off-by: Alvaro Bueno <alvaro.bueno@mailchimp.com>
@delagroove
fix: lint errors
6e42b9d 
Signed-off-by: Alvaro Bueno <alvaro.bueno@mailchimp.com>
@delagroove delagroove changed the title Feature/stripe sca WIP Feature/stripe sca Aug 5, 2021
@delagroove delagroove changed the title WIP Feature/stripe sca Feature/stripe sca Aug 18, 2021
@delagroove
fix: keep stripe method
1aa98dc 
Signed-off-by: Alvaro Bueno <alvaro.bueno@mailchimp.com>
@delagroove delagroove requested review from Akarshit and a team August 18, 2021 22:11
@delagroove
fix: lint
1669dc8 
Signed-off-by: Alvaro Bueno <alvaro.bueno@mailchimp.com>
@delagroove
fix: remove stripe old payment method, SCA remains
73623ca 
Signed-off-by: Alvaro Bueno <alvaro.bueno@mailchimp.com>
@delagroove delagroove merged commit 8b0aa40 into trunk Oct 16, 2021
@delagroove delagroove deleted the feature/stripe-sca branch October 16, 2021 15:02
@rc-publisher
Copy link
Collaborator

🎉 This PR is included in version 5.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rc-publisher rc-publisher added the released Applied automatically by semantic-release label Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akarshit Akarshit Awaiting requested review from Akarshit

@spencern spencern Awaiting requested review from spencern

Assignees
No one assigned
Labels
released Applied automatically by semantic-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@delagroove @rc-publisher @janus-reith