Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated UI for all tax settings #127

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

aldeed
Copy link
Contributor

@aldeed aldeed commented Dec 4, 2019

Resolves #57
Resolves #74
Impact: minor
Type: feature

All Settings -> Taxes UI is updated to use React Hooks, GraphQL, and MUI.

Testing

Test everything on the tax settings page either using this API branch, or after it is merged: reactioncommerce/reaction#5852

Use GraphQL and React hooks

Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. I'll approve once my comments are resolved on the API repo.

@mikemurray mikemurray merged commit 1be9955 into trunk Dec 5, 2019
@aldeed aldeed deleted the feat-aldeed-tax-settings-and-rates branch December 5, 2019 23:22
@kieckhafer kieckhafer mentioned this pull request Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[demetorization][blaze] Tax Rates (included/taxes-rates) [demetorization] Taxes (core/taxes)
2 participants