fix: made bin/setup always run from the desired path #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: major
Type: bugfix
Issue
The general problem is that the
find
used inbin/setup
is run from the PWD the script is run from.The expected outcome is that
bin/setup
should only copy environment variables found within this project.Right now running
make init
in reaction-platform copies the environment variables from every project's.env.example
files into almost every.env
file of every other project.This is because in this case the
find
command used to find all.env.example
files is being run from the platform directory, and thus all cloned projects within it are found by thefind
.Solution
I made
bin/setup
cd
to the root of the project before running thefind
.This also prevents us from needing the
$__dir
variable we were using when referring to files within the script.Testing
bin/setup
from the root of this project (which is the only place it used to work from).bin/setup
from any other folder, such asreaction-platform
or a folder that contains other reaction projects.For both of these cases, verify that your working directory does not change. It shouldn't, because the
cd
happens within a function and is not expected to affect your shell directory.