chore: use published image for docker-compose #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
rosshadden
approved these changes
Dec 10, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: chore
Changes
When you clone this branch and run
docker-compose up, it will now pull and use the latest publishedreactioncommerce/admin:trunkimage from DockerHub instead of building an image usingDockerfile-dev. Host files are not linked in, NPM deps are not reinstalled, and the built Node app will run instead of the Meteor app.Breaking changes
Breaking only for devs who will now need to run
ln -s docker-compose.dev.yml docker-compose.override.ymlto get the previous behavior.Testing
dc upstarts quickly and in prod mode. (You should not see anything about Meteor in the logs.)dc down, runln -s docker-compose.dev.yml docker-compose.override.ymland thendc upagain. Verify it now starts in dev mode and reloads when you change files.dc down, runrm docker-compose.override.ymlto remove the override file. It should be back to running in prod mode when you dodc up.