Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show product not found in products table #167

Merged
merged 3 commits into from
Jan 19, 2020

Conversation

trojanh
Copy link
Contributor

@trojanh trojanh commented Dec 23, 2019

Signed-off-by: trojanh rajan.tiwari@kiprosh.com

Resolves #162
Impact: minor
Type: bugfix

Issue

Do not hide the products table if no products are present instead show no products found.

Solution

image

Signed-off-by: trojanh <rajan.tiwari@kiprosh.com>
@aldeed
Copy link
Contributor

aldeed commented Dec 24, 2019

Thanks @trojanh ! Assigned @mikemurray to review when he's back from vacation. It looks fine to me, but Mike will know whether this is the correct way to show the empty table. (We'll hopefully be replacing all tables with the Catalyst table soon anyway.)

@trojanh
Copy link
Contributor Author

trojanh commented Dec 26, 2019

I had seen this React-Table usage but I focused on fixing the issue for now as I was not sure if that was the accepted approach.

Catalyst table looks great, would love help with that @aldeed .

@janus-reith
Copy link
Contributor

janus-reith commented Jan 7, 2020

products.js here has an import which is not present anymore:
import { getTagIds as getIds } from "/lib/selectors/tags";

Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change. Can you make the height of the textNotFound cell 50px? This will give grey background has some vertical space around the text, and make it look more like the rows when the table has data.

@willopez
Copy link
Member

willopez commented Jan 9, 2020

@trojanh please update this branch by merging in the latest trunk

Signed-off-by: trojanh <rajan.tiwari@kiprosh.com>
@trojanh
Copy link
Contributor Author

trojanh commented Jan 14, 2020

@mikemurray @willopez I have made the requested changes. Sorry for the delay.

@janus-reith it seems that was already handled on trunk by some other PR.

…nto products-page-fix

Signed-off-by: trojanh <rajan.tiwari@kiprosh.com>
@aldeed aldeed merged commit 65b47ec into reactioncommerce:trunk Jan 19, 2020
This was referenced Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product table is hidden when no products are found
5 participants