-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show product not found in products table #167
Conversation
Signed-off-by: trojanh <rajan.tiwari@kiprosh.com>
Thanks @trojanh ! Assigned @mikemurray to review when he's back from vacation. It looks fine to me, but Mike will know whether this is the correct way to show the empty table. (We'll hopefully be replacing all tables with the Catalyst table soon anyway.) |
I had seen this React-Table usage but I focused on fixing the issue for now as I was not sure if that was the accepted approach. Catalyst table looks great, would love help with that @aldeed . |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change. Can you make the height of the textNotFound
cell 50px? This will give grey background has some vertical space around the text, and make it look more like the rows when the table has data.
@trojanh please update this branch by merging in the latest |
Signed-off-by: trojanh <rajan.tiwari@kiprosh.com>
@mikemurray @willopez I have made the requested changes. Sorry for the delay. @janus-reith it seems that was already handled on |
…nto products-page-fix Signed-off-by: trojanh <rajan.tiwari@kiprosh.com>
ce7274a
to
05ca14d
Compare
Signed-off-by: trojanh rajan.tiwari@kiprosh.com
Resolves #162
Impact: minor
Type: bugfix
Issue
Do not hide the products table if no products are present instead show
no products found
.Solution