Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use updateProductVariantPrices mutation to save variant price #172

Merged
merged 3 commits into from
Jan 10, 2020

Conversation

trojanh
Copy link
Contributor

@trojanh trojanh commented Jan 7, 2020

Signed-off-by: trojanh rajan.tiwari@kiprosh.com

Resolves #170
Impact: breaking|major
Type: bugfix

Issue

Unable to set product variant price

  1. Create a new variant.
  2. Add a price to it
  3. Refresh to see that the price is reset to zero.

Solution

Use updateProductVariantPrices mutation to set the price.

Breaking changes

none

Testing

  1. Create a new variant.
  2. Add a price to it
  3. Refresh to see that the price is NOT reset to zero.
  4. Also publish and refresh the variant to see it the changes get saved.

variant-price-update

Signed-off-by: trojanh <rajan.tiwari@kiprosh.com>
@spencern
Copy link
Contributor

spencern commented Jan 8, 2020

Thanks for the PR!

Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change necesary, otherwise looks good.

@manueldelreal
Copy link
Member

Save for @willopez review comment and the linting errors on the checks this one does permit the price update via the admin ui.

Signed-off-by: trojanh <rajan.tiwari@kiprosh.com>
…nto set-variant-price

Signed-off-by: trojanh <rajan.tiwari@kiprosh.com>
@trojanh
Copy link
Contributor Author

trojanh commented Jan 10, 2020

@willopez I have replaced all occurrences of Alerts.alert and Alert.toast to use snackbar. Also, fixed the linting error and rebased the branch. Please review the changes.

@willopez
Copy link
Member

thanks @trojanh!

@willopez willopez merged commit f72bf93 into reactioncommerce:trunk Jan 10, 2020
@kieckhafer kieckhafer mentioned this pull request Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v3.0.0] Cannot set price for variants
4 participants