Add product page title #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: trojanh <rajan.tiwari@kiprosh.com>
willopez
requested changes
Jan 9, 2020
Signed-off-by: trojanh <rajan.tiwari@kiprosh.com>
trojanh
force-pushed
the
add-product-page-title
branch
from
229e5f9
to
393d470
Compare
|
@willopez fixed the linting errors and signed the commits, thanks for pointing. |
trojanh
force-pushed
the
add-product-page-title
branch
2 times, most recently
from
2397efd
to
5e9a308
Compare
Signed-off-by: trojanh <rajan.tiwari@kiprosh.com>
trojanh
force-pushed
the
add-product-page-title
branch
from
5e9a308
to
0190702
Compare
…nto add-product-page-title Signed-off-by: trojanh <rajan.tiwari@kiprosh.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves N.A.
Impact: minor
Type: bugfix
Issue
Product and Variants page does not show page titles.
Solution
Add page title for products page using Helmet.