refactor: get permissions from groups, not user object
#187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t user Signed-off-by: Erik Kieckhafer <ek@ato.la>
…permissions Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
mikemurray
previously requested changes
Jan 24, 2020
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
kieckhafer
dismissed
mikemurray’s stale review
@mikemurray comments addressed, ready for another check
This was referenced Jan 31, 2020
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #issueNumber
Impact: major
Type: featurer|refactor
Issue
User permissions are currently checked against the
user.rolesobject that is on auser. In the API, we've updated how permission work and now getpermissions(formerlyroles) by querying the groups a user belongs too, and attaching the permissions to a user based on the groups permissions.Solution
Update
reaction-adminto getpermissionsbased off ofaccount.groupsrather thanuser.roles. In addition, update allReaction.hasPermission()checks to use the new permissions we use in the api.Breaking changes
None
Testing
Reaction.hasPermissionworks as expected