Feat 3.0 change port #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
The storefront style guide runs on 4040 already Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
mikemurray
approved these changes
Oct 21, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
Issue
The server was running on 4040 but the storefront style guide runs on that port.
Solution
Changing to port 4080.
Breaking changes
Part of overall breaking changes for 3.0.0, but this app isn't released yet so technically no.
Testing
Start the API, and then start this app. Go to http://localhost:4080 in the browser and verify you can use the Reaction Admin as expected.