feat: respect .env files #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>
brent-hoover
force-pushed
the
respect-env-files
branch
from
6598531
to
ec4f0f5
Compare
delagroove
approved these changes
Dec 13, 2021
Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>
brent-hoover
force-pushed
the
respect-env-files
branch
from
3820579
to
7f13ab2
Compare
Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>
|
🎉 This PR is included in version 4.0.0-beta.15 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: feature
Issue
By default the project does not respect .env files even though it uses envalid. This makes it hard to run it at the command line w/o using a tool like direnv.
Solution
Add the dotenv package and bootstrap dotenv during startup before envalid is processed.
Also
Add npm-check package for easy checking/upgrades of packages
Breaking changes
None
Testing
Test that it works in both standalone and in docker