Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat aldeed 5417 remove operator prefix #6

Merged
merged 16 commits into from
Oct 17, 2019

Conversation

aldeed
Copy link
Contributor

@aldeed aldeed commented Oct 17, 2019

Resolves #5417
Impact: breaking
Type: feature

Changes

  • Remove /operator prefix from all routes
  • Fixes to "current shop" and app loading global state such that there is less flashing of various component states when logging in.
  • The shop creation form that shows when there is no primary shop now changes button text when submitting so it's clear it's happening.
  • Adjustments to Meteor pub/sub. Accounts are now subscribed in a simpler and more resilient way. "Package" collection is subscribed to only where needed, directly in the components.
  • The marketplace plugin is removed
  • Remove a bunch of unused code, such as Reaction methods, unused Meteor methods on the server
  • Remove some Blaze code for EmailConfig, now use a new "EmailSettings" block region

Breaking changes

  • All links to Reaction Admin pages that begin with /operator will no longer load the correct page
  • Anything relying on the removed marketplace plugin being registered will need to be updated
  • Anything using the shop/createShop Meteor method will need to be rewritten. There is a createShop GraphQL mutation that may work as an alternative.
  • If you were previously using registry with provides: ["emailProviderConfig"], you now need to register a component for the "EmailSettings" block region in client plugin code instead.

Testing

Verify everything works and routes no longer begin with /operator. (Note: hydra oauth routes are not yet working)

Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Subscribe to Packages only where necessary.
We're trying to get rid of it.

Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Remove setting of default payment that isn't used anywhere

Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
@aldeed aldeed self-assigned this Oct 17, 2019
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI loads and works mostly. For the things that do not, they have been captured in various tickets.

@mikemurray mikemurray merged commit e03ea95 into trunk Oct 17, 2019
@mikemurray mikemurray deleted the feat-aldeed-5417-remove-operator-prefix branch October 17, 2019 21:45
@kieckhafer kieckhafer mentioned this pull request Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants