feat: use Notistack to display user notifications #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
|
Try merging latest trunk to fix CI |
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
|
@aldeed thanks that fixed the CI build. @mikemurray this is ready for review now. |
mikemurray
deleted the
feat-integrate-toast-notifications-in-products-view
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: reactioncommerce/reaction#5501
Impact: Minor
Type: feature
Corresponding PR on the API: reactioncommerce/reaction#5746
Issue
In order to provide better UX replace inline alerts with notifications(Snackbars).
Solution
Use Notistack(integrates well with MUI) to display notifications and manage related state.
Testing