Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gql query param #83

Merged
merged 1 commit into from
Nov 5, 2019
Merged

fix: gql query param #83

merged 1 commit into from
Nov 5, 2019

Conversation

mikemurray
Copy link
Member

Impact: critical
Type: bugfix

Issue

Query missing $ in front of shopId

Solution

Add the $

Testing

  1. Ensure the app starts and the Navigation admin loads. (you cannot save it, that's another issue that's already been logged)

@mikemurray
fix: gql query param
1628ad0 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
kieckhafer
kieckhafer approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kieckhafer kieckhafer merged commit f120cc4 into trunk Nov 5, 2019
@mikemurray mikemurray deleted the fix-mikemurray-nav-query branch November 5, 2019 22:21
@kieckhafer kieckhafer mentioned this pull request Feb 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kieckhafer kieckhafer kieckhafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikemurray @kieckhafer