Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove yarn.lock so applications get security fixes #412

Closed
focusaurus opened this issue Jun 13, 2019 · 1 comment · Fixed by #413
Closed

Remove yarn.lock so applications get security fixes #412

focusaurus opened this issue Jun 13, 2019 · 1 comment · Fixed by #413
Labels
released Applied automatically by semantic-release

Comments

@focusaurus
Copy link
Contributor

Type: minor

Describe the bug

If this library is intended to be used as an npm dependency, including a yarn.lock is not something we should do. That will prevent semver minor patches from getting installed in the applications using this library.
focusaurus added a commit that referenced this issue Jun 13, 2019
@focusaurus
fix: remove yarn.lock file
957b6d5 
This does not belong in a library.
It prevents security fixes flowing through to applications.

Resolves #412

Signed-off-by: Peter Lyons <pete@reactioncommerce.com>
@focusaurus focusaurus mentioned this issue Jun 13, 2019
Merged
focusaurus added a commit that referenced this issue Jun 13, 2019
@focusaurus
fix: remove yarn.lock file
7327e10 
This does not belong in a library.
It prevents security fixes flowing through to applications.

Resolves #412

Signed-off-by: Peter Lyons <pete@reactioncommerce.com>
focusaurus added a commit that referenced this issue Jun 14, 2019
@focusaurus
fix: remove yarn.lock file
d4f6344 
This does not belong in a library.
It prevents security fixes flowing through to applications.

Resolves #412

Signed-off-by: Peter Lyons <pete@reactioncommerce.com>
@rc-publisher
Copy link
Collaborator

🎉 This issue has been resolved in version 0.65.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rc-publisher rc-publisher added the released Applied automatically by semantic-release label Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released Applied automatically by semantic-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove yarn.lock file reactioncommerce/reaction-component-library
2 participants
@focusaurus @rc-publisher