Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StripeForm error #326

Merged
merged 2 commits into from
Oct 11, 2018
Merged

Fix StripeForm error #326

merged 2 commits into from
Oct 11, 2018

Conversation

aldeed
Copy link
Contributor

@aldeed aldeed commented Oct 11, 2018

Resolves #325
Impact: minor
Type: bugfix

Changes

  • Remove withTheme to hopefully resolve the error in the linked issue. This error does not happen locally, even in the production build, so this is only an educated guess at what is causing it.
  • Correct some omissions in the installation docs, unrelated

Breaking changes

None

Testing

Hopefully there will not be errors when this PR preview is deployed. Otherwise just review the code changes.

@aldeed aldeed requested a review from nnnnat October 11, 2018 15:33
@aldeed aldeed self-assigned this Oct 11, 2018
@aldeed aldeed added this to the Oxford milestone Oct 11, 2018
@machikoyasuda
Copy link
Contributor

🚀 Preview deployed

Built with commit 876d6f9

https://deploy-preview-326--stoic-hodgkin-c0179e.netlify.com

Copy link
Contributor

@nnnnat nnnnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working in the deploy preview 👍

@nnnnat nnnnat merged commit a95899d into master Oct 11, 2018
@nnnnat nnnnat deleted the fix-325-aldeed-stripe-form-error branch October 11, 2018 17:10
@rc-publisher
Copy link
Collaborator

🎉 This PR is included in version 0.45.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError in StripeForm component on staging
4 participants