fix: Reorder subprojects based on dependency order for startup #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
focusaurus
force-pushed
the
repo-order
branch
from
a157503
to
08bc70e
Compare
Signed-off-by: Peter Lyons <pete@reactioncommerce.com>
ticean
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: refactor
Issue
List subprojects in startup dependency order just for clarity. This doesn't guarantee clean startup or account for the delay between service start and service ready but it at least is logical.
Based on @trojanh's comment here: #97 (comment)
Breaking changes
Not breaking.
Testing
SUBPROJECT_REPOSinconfig.local.mk