Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archive Product function still labeled "Delete Product" #2014

Closed
NahomAgidew opened this issue Mar 19, 2017 · 4 comments
Closed

Archive Product function still labeled "Delete Product" #2014

NahomAgidew opened this issue Mar 19, 2017 · 4 comments
Assignees
@michael-alade
Milestone
v1.0.x

Comments

@NahomAgidew
Copy link

NahomAgidew commented Mar 19, 2017 •
edited by michael-alade
Loading

When in edit mode, I tried to delete a product by clicking on the delete (red trash can) button but instead it asks if I want to archive the product and it will archive it. Even when I hover over the trash can button it has a tooltip that says: "Delete Product".
@michael-alade
Copy link

@NahomAgidew What version of reaction are you running?

@NahomAgidew
Copy link
Author

The latest i.e v 1.0

@brent-hoover
Copy link
Collaborator

We don't allow deleting a product once it's been created, but agreed it should say Archive everywhere, not Delete.

@brent-hoover brent-hoover changed the title Cannot delete a product. Archive Product function still labeled "Delete Product" Mar 20, 2017
@brent-hoover brent-hoover added this to the v1.0.0 milestone Mar 22, 2017
@michael-alade michael-alade self-assigned this Mar 22, 2017
@michael-alade michael-alade mentioned this issue Mar 22, 2017
Merged
@ghost ghost added review and removed in progress labels Mar 22, 2017
@brent-hoover
Copy link
Collaborator

Closed via #2030

@ghost ghost removed the review label Mar 28, 2017
@joykare joykare mentioned this issue Apr 21, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michael-alade michael-alade

Labels
None yet
Projects
None yet
Milestone
v1.0.x
Development

No branches or pull requests
3 participants
@brent-hoover @NahomAgidew @michael-alade