Cart items picture displays placeholder (sometimes) when product has variants

[speedingdeer]

Expected behavior

Cart displays the selected product variant's picture

Actual behavior

Cart display nothing (sometimes) instead of selected product variant's picture

Steps to reproduce the behavior

Create few product variants and add pictures for each of them. Next as user select few and them to cart. Click on the cart image and check if the pictures in cart match the ordered variant pictures.

Versions

(run reaction -v from your reaction directory)
Node: 8.1.4
NPM: 5.0.3
Meteor Node: 4.8.5
Meteor NPM: 4.6.1
Reaction CLI: 0.20.0
Reaction: 1.5.6
Reaction branch: master
Docker: 17.09.0-ce

[brent-hoover]

I'm seeing this as well. It has to do with ReactionProduct.selectedVariant() is sometimes returning null. Trying to get this solved today.

[brent-hoover]

Which is just caused by the fact that sometimes no variant is selected, and sometimes the top-level variant is selected. If you select a variant, then the image is shown. And refreshing seems to always select the top-level variant.

[brent-hoover]

I believe this was fixed via #3267 but needs to be verified

[brent-hoover]

@codejockie Did you verify that this issue still occurs on master?

[codejockie]

@zenweasel yes I did that. It still occurs on master.