Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cart items image displays placeholder #3374

Conversation

codejockie
Copy link
Contributor

Resolves #3263

This PR fixes a bug where items in cart images are sometimes not showing or displays placeholder.

How to Test

  1. Login as an Admin or Merchant
  2. Create few products w/ or w/o variants and add pictures for each.
  3. Add created products to cart.
  4. Click on cart
  5. Observe that images are shown for each items in cart

Copy link
Contributor

@spencern spencern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. 👍

@spencern spencern changed the base branch from master to release-1.6.1 December 12, 2017 00:22
@spencern spencern merged commit 29a2950 into release-1.6.1 Dec 12, 2017
@spencern spencern deleted the kennedy-fix-cart-item-pictures-display-placeholder-3263 branch December 12, 2017 00:23
@spencern spencern mentioned this pull request Dec 12, 2017
Akarshit pushed a commit that referenced this pull request Jan 7, 2018
…pictures-display-placeholder-3263

Fix cart items image displays placeholder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants