Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not possible to overwrite layouts and/or INDEX_OPTIONS without being forced to use Blaze #3523

Closed
prinzdezibel opened this issue Jan 19, 2018 · 0 comments · Fixed by #3645
Closed

Not possible to overwrite layouts and/or INDEX_OPTIONS without being forced to use Blaze #3523

prinzdezibel opened this issue Jan 19, 2018 · 0 comments · Fixed by #3645
Labels
enhancement For issues that describe a feature that needs to be added, changed, or removed, but is not a bug

Comments

@prinzdezibel
Copy link
Contributor

prinzdezibel commented Jan 19, 2018 •
edited
Loading

Issue:
coreLayout.js renders the content of <main> through Blaze in an unconditional manner.

This forces users who wish to write customized views to write deprecated Blaze templates. That's not good.

An intermediary solution would be to render a Blaze , if a Blaze template with the passed name is available. If not, coreLayout could probe for a React component and use that as fallback.

That way the old behaviour is guaranteed, even if there's a Blaze template and a React component with the same name (which should not happen anyway, because Blaze templates should be camelcased and React component name start with upper letter).
prinzdezibel added a commit that referenced this issue Jan 19, 2018
@prinzdezibel
coreLayout should probe for React component as fallback
6e212ae 
Closes #3523

This PR enables users to overwrite layouts and/or INDEX_OPTIONS without
being forced to use deprecated Blaze templates.

Through rendering Blaze templates in a precendential manner, the old behaviour
should be guaranteed, even if there's a React component with the same
name.
@prinzdezibel prinzdezibel mentioned this issue Jan 19, 2018
Merged
@prinzdezibel prinzdezibel added enhancement For issues that describe a feature that needs to be added, changed, or removed, but is not a bug architecture-review labels Jan 21, 2018
@spencern spencern mentioned this issue Feb 5, 2018
Merged
@spencern spencern mentioned this issue Feb 16, 2018
Merged
@spencern spencern mentioned this issue Mar 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement For issues that describe a feature that needs to be added, changed, or removed, but is not a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 1.8.0 reactioncommerce/reaction
1 participant
@prinzdezibel