Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot create password when invited to create account #3805

Closed
spencern opened this issue Feb 21, 2018 · 1 comment · Fixed by #3645
Closed

Cannot create password when invited to create account #3805

spencern opened this issue Feb 21, 2018 · 1 comment · Fixed by #3645
Assignees
Labels
bug For issues that describe a defect or regression in the released software

Comments

@spencern
Copy link
Contributor

Summary
When being invited to create an account as a shop manager or a merchant shop owner, the password overlay spinner is never turned off.
image

It appears that the lifecycle method componentWillReceiveProps is never fired for this password overlay.

https://github.com/reactioncommerce/reaction/blob/release-1.8.0/imports/plugins/core/accounts/client/components/updatePasswordOverlay.js#L33

As seen in the gif here: http://g.recordit.co/F9BwrqGl2g.gif, if you manually set the state for "showSpinner" to false, you are able to enter your password and complete creating your account.

Steps to reproduce

  1. Use branch release-1.8.0
  2. invite a user to become a shop manager from the accounts screen
  3. Follow that link in a new session (incognito or similar)
  4. Observer spinner
  5. In react devtools find the Reaction(UpdatePasswordOverlay) component and set showSpinner` to false
  6. Input your password and see that your account is created
@spencern spencern added bug For issues that describe a defect or regression in the released software impact-critical labels Feb 21, 2018
@Akarshit Akarshit self-assigned this Feb 21, 2018
spencern added a commit that referenced this issue Feb 21, 2018
…password

Fixes #3805: remove spinner before mounting
@brent-hoover
Copy link
Collaborator

Closed via #3806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues that describe a defect or regression in the released software
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants