[Marketplace] Inviting someone to create a new shop or affiliate shop should automatically grant that user appropriate permissions when registered #2538

impactmass · 2017-07-07T20:52:17Z

Resolves #2186

How to Test:

Pull and run this branch. Log in as Marketplace Owner.
Setup your email config (if you don't have it)
Go to Shop Settings in the dashboard.
Open the Invite Owner Form under the marketplace plugin section
Fill the form (Use a valid email so you can follow the link that gets sent to register)
Follow link in email and on completing the "reset password" form, check that the new account have access to dashboard actions for the new shop.

…il template

…reaction into seun-invite-owner-2186

spencern · 2017-07-29T07:03:28Z

This is done more-or-less, but currently UI testing is blocked by #2605

impactmass · 2017-08-01T15:45:00Z

With the PR fix #2612 I opened for the passwordReset bug, (when merged) the block mentioned above will be removed. But there's another issue I just found. The SortableTable received some updates (I believe via this PR #2597), and that's throwing no data error with Accounts table. I'm taking a look into that too.

spencern · 2017-08-01T23:09:12Z

In light of the above comment, I'm re-adding [WIP] to this issue.

* Fix missing component errors and component name reference * Fix missing component imports and references * Return use Component. for core comp * Change componenent ref in resetPassword * Update Match check to prevent error in cart after password reset * Add todo comment on the check on cart/merge * Update to only comment and fix test

impactmass · 2017-08-02T16:47:54Z

@spencern you can test it out now

spencern · 2017-08-03T17:00:38Z

Seems that i18n isn't working in some places

gonna see if I can fix this quickly

spencern · 2017-08-03T17:06:30Z

Loads with primary shop as "active" after sign-in. I'll see if I can update that as well.

impactmass · 2017-08-03T17:08:10Z

The i18n issue is inconsistent. It shows up sometimes. Sometimes it doesn't. I tried digging in a little too, but no luck

spencern · 2017-08-03T17:31:20Z

Seems like something is wrong with the cart too

On a refresh, twice I've seen the cart icon spin forever

Refreshing the page in this scenario throws the error again and the cart continues to spin. The only solution I've seen is to log out and log back in.

Throws this server error:

Exception from sub Cart id iRN9khFanLydgxGFG WriteError({"code":11000,"index":0,"errmsg":"E11000 duplicate key error collection: meteor.Cart index: c2_userId dup key: { : \"f2z6mjMTHF3eCwsjb\" }","op":{"sessionId":"FyBSLKiJdCFsodehi","userId":"f2z6mjMTHF3eCwsjb","_id":"Xa2L3dsxf9ACmxYte","shopId":"yjgpZxbwBTCpp3cZg","createdAt":"2017-08-03T17:30:13.604Z","workflow":{"status":"new"}}})
    at Object.Future.wait (/Users/sn/.meteor/packages/meteor-tool/.1.5.1.1bs7ixz++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/server-lib/node_modules/fibers/future.js:449:15)
    at [object Object].<anonymous> (packages/meteor.js:213:24)
    at [object Object].MongoConnection.(anonymous function) [as insert] (packages/mongo/mongo_driver.js:778:49)
    at Object.<anonymous> (packages/matb33_collection-hooks.js:395:18)
    at Object.collection.(anonymous function) [as insert] (packages/matb33_collection-hooks.js:146:21)
    at [object Object].insert (packages/mongo/collection.js:526:37)
    at [object Object].Mongo.Collection.(anonymous function) (packages/aldeed_collection2-core.js:232:19)
    at [object Object].Mongo.Collection.(anonymous function) [as insert] (packages/dispatch_run-as-user.js:325:19)
    at [object Object].cartCreateCart (server/methods/core/cart.js:265:44)
    at packages/check.js:129:16
    at [object Object]._.extend.withValue (packages/meteor.js:1126:17)
    at Object.exports.Match._failIfArgumentsAreNotAllChecked (packages/check.js:128:41)
    at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1765:18)
    at packages/ddp-server/livedata_server.js:1686:15
    at [object Object]._.extend.withValue (packages/meteor.js:1126:17)
    at packages/ddp-server/livedata_server.js:1684:36

spencern

Issue with cart in loading process forever is a blocker. We need to determine if that's from this PR. If it is we need to fix it here, otherwise we can fix it in the marketplace branch.

We also need to determine if the i18n issues are from this PR

brent-hoover · 2017-08-03T21:41:52Z

I think the i18n issue is in development as well: #2593

spencern · 2017-08-04T06:54:12Z

I didn't have a chance to work on the cart creation issue tonight but will jump on it first thing in the am.

impactmass · 2017-08-04T09:15:29Z

Thanks @spencern. I'll also dig into it, maybe I'll find a solution before you're back. (since it's best to get this merged as soon as possible, as other things depend on it)

aaronjudd

Tested, looks good to me. (I've not seen the cart issue) (i18n is a separate issue as well)

impactmass · 2017-08-04T16:07:40Z

thanks @aaronjudd. Re the cart issue, my last commit fixed it (hence it wasn't happening for you).
I just need to code review this with @spencern now

spencern

Looks good to me.

spencern requested review from spencern and removed request for spencern July 11, 2017 16:38

spencern mentioned this pull request Jul 28, 2017

[EPIC][Marketplace] Marketplace Permissions #2183

Closed

12 tasks

Add back initial setup from previous commits - inviteOwner method, ma…

862d0e1

…il template

impactmass force-pushed the seun-invite-owner-2186 branch from 8c97d23 to 862d0e1 Compare July 28, 2017 20:53

impactmass added 6 commits July 28, 2017 21:54

Merge branch 'marketplace' into seun-invite-owner-2186

f2fea8c

fix failing test

3e757c0

Merge branch 'seun-invite-owner-2186' of github.com:reactioncommerce/…

c2f46e8

…reaction into seun-invite-owner-2186

Add form to call invite user form marketplace settings dashgs

4415585

Set invited user as owner of new shop and set preferences

452c2dd

Fix typo, and set default option

548f034

Merge branch 'marketplace' into seun-invite-owner-2186

55166ed

spencern mentioned this pull request Jul 29, 2017

[1.5.0] Reset password link and overlays broken #2605

Closed

impactmass added 5 commits July 31, 2017 15:55

Merge branch 'marketplace' into seun-invite-owner-2186

04b3ce4

Resolve lint import error

1d882b0

Fix error in createShop; and update publication to limit to shop

e8e6b19

Merge branch 'marketplace' into seun-invite-owner-2186

4368720

Merge seun-fix-passwordoverlay-comp-2605 into seun-invite-owner-2186

57a797a

impactmass added 2 commits August 1, 2017 18:16

Updating sortable for pre-passed data

58b691e

wip

1ca913e

impactmass added 4 commits August 2, 2017 15:38

Convert comp to react; and use registerComponent

904fc7a

Use correct Id on shopcreate

7b8e36c

Merge branch 'marketplace' into seun-invite-owner-2186

18263c1

impactmass requested a review from spencern August 2, 2017 16:47

impactmass mentioned this pull request Aug 3, 2017

[Marketplace] Owner permission should be transferable #2188 #2609

Merged

spencern suggested changes Aug 3, 2017

View reviewed changes

Set correct shopId when user updates password for the first time

9b98390

aaronjudd requested a review from spencern August 4, 2017 03:25

aaronjudd assigned aaronjudd and unassigned aaronjudd Aug 4, 2017

aaronjudd self-requested a review August 4, 2017 03:25

Merge branch 'marketplace' into seun-invite-owner-2186

88557b3

This was referenced Aug 4, 2017

[Marketplace] Owner permission should be transferable #2188

Closed

[Marketplace] Inviting someone to create a new shop or affiliate shop should automatically grant that user appropriate permissions when registered #2186

Closed

Switch getShopId to getPrimaryShopId in shopAutoValue

dd43f41

aaronjudd approved these changes Aug 4, 2017

View reviewed changes

impactmass and others added 4 commits August 4, 2017 18:03

AddressBook should be an array

b08923e

Update shopIdAutoValue to switch based on if merchantCart enabled

aaee3f3

should be merchantCart not merchantCarts

6faba40

Merge branch 'marketplace' into seun-invite-owner-2186

43b869a

spencern approved these changes Aug 4, 2017

View reviewed changes

spencern merged commit 31adcf1 into marketplace Aug 4, 2017

spencern deleted the seun-invite-owner-2186 branch August 4, 2017 18:12

spencern mentioned this pull request Oct 11, 2017

Release 1.5.0 #3089

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Marketplace] Inviting someone to create a new shop or affiliate shop should automatically grant that user appropriate permissions when registered #2538

[Marketplace] Inviting someone to create a new shop or affiliate shop should automatically grant that user appropriate permissions when registered #2538

impactmass commented Jul 7, 2017 •

edited

Loading

spencern commented Jul 29, 2017

impactmass commented Aug 1, 2017 •

edited

Loading

spencern commented Aug 1, 2017

impactmass commented Aug 2, 2017

spencern commented Aug 3, 2017

spencern commented Aug 3, 2017

impactmass commented Aug 3, 2017

spencern commented Aug 3, 2017 •

edited

Loading

spencern left a comment

brent-hoover commented Aug 3, 2017

spencern commented Aug 4, 2017

impactmass commented Aug 4, 2017

aaronjudd left a comment •

edited

Loading

impactmass commented Aug 4, 2017

spencern left a comment

[Marketplace] Inviting someone to create a new shop or affiliate shop should automatically grant that user appropriate permissions when registered #2538

[Marketplace] Inviting someone to create a new shop or affiliate shop should automatically grant that user appropriate permissions when registered #2538

Conversation

impactmass commented Jul 7, 2017 • edited Loading

spencern commented Jul 29, 2017

impactmass commented Aug 1, 2017 • edited Loading

spencern commented Aug 1, 2017

impactmass commented Aug 2, 2017

spencern commented Aug 3, 2017

spencern commented Aug 3, 2017

impactmass commented Aug 3, 2017

spencern commented Aug 3, 2017 • edited Loading

spencern left a comment

Choose a reason for hiding this comment

brent-hoover commented Aug 3, 2017

spencern commented Aug 4, 2017

impactmass commented Aug 4, 2017

aaronjudd left a comment • edited Loading

Choose a reason for hiding this comment

impactmass commented Aug 4, 2017

spencern left a comment

Choose a reason for hiding this comment

impactmass commented Jul 7, 2017 •

edited

Loading

impactmass commented Aug 1, 2017 •

edited

Loading

spencern commented Aug 3, 2017 •

edited

Loading

aaronjudd left a comment •

edited

Loading