Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Setting product visibility is not reflected in the Product Grid reactively #2561

Merged
merged 13 commits into from
Jul 25, 2017
Merged

Fix Setting product visibility is not reflected in the Product Grid reactively #2561

merged 13 commits into from
Jul 25, 2017

Conversation

desaawa
Copy link
Contributor

@desaawa desaawa commented Jul 17, 2017 •
edited
Loading

This resolves #2522

Steps to Test

  1. Create a product, set it to visible and publish
  2. Observe it in the Product grid in an incognito browser, as non-admin
  3. Set it to "Private" and publish
  4. Observe that the disappears from the grid
  5. Set it to "Public" and publish
  6. Observe that it comes back on the grid reactively.

@desaawa desaawa changed the title [WIP] Fix Setting product visibility is not reflected in the Product Grid reactively Fix Setting product visibility is not reflected in the Product Grid reactively Jul 17, 2017
kieckhafer
kieckhafer reviewed Jul 17, 2017
View reviewed changes
Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm reactivity for already existing products....

However, if I create a new product in an admin window, I need to refresh my Incognito non-admin in order to see the product the first time.

@aaronjudd
Copy link
Contributor

Also confirming works for existing products. Did not work for new products.

Since that is step one of #2522 steps to reproduce is a new product, let's get that working before accepting this PR.

I also cloned and existing product, and published it, and all my products in the incognito grid disappeared.

aaronjudd
aaronjudd suggested changes Jul 17, 2017
View reviewed changes
Copy link
Contributor

@aaronjudd aaronjudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Publish new products needs revisiting.

@desaawa
Copy link
Contributor Author

desaawa commented Jul 19, 2017

@aaronjudd, @kieckhafer this should work now.

@aaronjudd
Copy link
Contributor

Tests are failing.

@desaawa
Copy link
Contributor Author

desaawa commented Jul 23, 2017

Tests fixed.

@aaronjudd aaronjudd merged commit 4f46714 into development Jul 25, 2017
@aaronjudd aaronjudd deleted the awa-fix-2522-product-visibility branch July 25, 2017 00:22
@aaronjudd
Copy link
Contributor

@awadesmoline When we see underscore/lodash -> we should be attempting to replace with native ES6. We should really try hard to not implement in new code.

jshimko added a commit that referenced this pull request Jul 25, 2017
@jshimko
Merge branch 'register-component-api' of github.com:reactioncommerce/…
131ca5f 
…reaction into register-component-api

* 'register-component-api' of github.com:reactioncommerce/reaction:
  Release 1.4.1 (#2583)
  LingoHub based on development (#2591)
  Fix Setting product visibility is not reflected in the Product Grid reactively (#2561)
@desaawa desaawa mentioned this pull request Jul 25, 2017
Closed
@desaawa
Copy link
Contributor Author

desaawa commented Jul 25, 2017

Okay @aaronjudd. Noted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kieckhafer kieckhafer kieckhafer left review comments

@aaronjudd aaronjudd aaronjudd approved these changes

@brent-hoover brent-hoover Awaiting requested review from brent-hoover

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@desaawa @aaronjudd @kieckhafer @spencern