Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Shop Manager" as a default group #2602

Merged
merged 16 commits into from
Jul 29, 2017
Merged

Add "Shop Manager" as a default group #2602

merged 16 commits into from
Jul 29, 2017

Conversation

impactmass
Copy link
Contributor

@impactmass impactmass commented Jul 27, 2017 •
edited
Loading

NB: To be merged after #2601

Add "Shop Manager" as a default group to the currently existing Owner, Customer and Guest groups.
This makes two admin groups: Owner and Shop Manager

To Test:

  • Start the app, and check that there's a default group for "Shop Manager"

Other UIX updates in this PR:

  • Sort groups to display higher permission groups at the top. With this "Owner" group stay at the top
  • Use first part of email, if account has no name
  • Show no dropdown popover if there's no groups in the list

@impactmass impactmass force-pushed the seun-add-shop-manager-default-group branch from 356e48b to 9b6abdd Compare July 28, 2017 13:01
@impactmass impactmass force-pushed the seun-migration-to-groups branch 2 times, most recently from ca4490c to 74dd3e9 Compare July 29, 2017 00:16
@impactmass impactmass changed the title [WIP] Add "Shop Manager" as a default group Add "Shop Manager" as a default group Jul 29, 2017
@impactmass impactmass changed the base branch from seun-migration-to-groups to marketplace July 29, 2017 18:26
@impactmass impactmass requested a review from spencern July 29, 2017 18:27
@spencern
Copy link
Contributor

Works. Merging.

@impactmass We should probably make the "enter" button submit the form during the design updates.

spencern
spencern approved these changes Jul 29, 2017
View reviewed changes
Copy link
Contributor

@spencern spencern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spencern spencern merged commit d2b0f3e into marketplace Jul 29, 2017
@spencern spencern deleted the seun-add-shop-manager-default-group branch July 29, 2017 23:07
@spencern spencern mentioned this pull request Oct 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencern spencern spencern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@impactmass @spencern