Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cart schema to include all product data #2610

Merged
merged 8 commits into from
Aug 2, 2017
Merged

Update cart schema to include all product data #2610

merged 8 commits into from
Aug 2, 2017

Conversation

kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Aug 1, 2017 •
edited
Loading

Update the cart schema, and addToCart function to include all data we store on the product.

@kieckhafer kieckhafer changed the title [WIP] Update cart schema to include all product data Update cart schema to include all product data Aug 1, 2017
@brent-hoover
Copy link
Collaborator

Looks like this is breaking a lot of tests

@kieckhafer
Copy link
Member Author

If you're wondering what getAutoValues is, this is the reference we used to figure out that it's a good fix: Meteor-Community-Packages/meteor-collection2#245

brent-hoover
brent-hoover approved these changes Aug 1, 2017
View reviewed changes
Copy link
Collaborator

@brent-hoover brent-hoover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Seems to be working without issue.

@aaronjudd aaronjudd merged commit 4f236cc into marketplace Aug 2, 2017
@aaronjudd aaronjudd deleted the ek-dataDataData branch August 2, 2017 16:31
@impactmass impactmass mentioned this pull request Sep 25, 2017
Closed
impactmass added a commit that referenced this pull request Sep 27, 2017
@impactmass
Migration - Update cart schema to include all product data #2610
52c95ae
@spencern spencern mentioned this pull request Oct 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronjudd aaronjudd aaronjudd approved these changes

@brent-hoover brent-hoover brent-hoover approved these changes

Assignees

@brent-hoover brent-hoover

@aaronjudd aaronjudd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kieckhafer @brent-hoover @aaronjudd