-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for error while archiving a product #2650
Conversation
@foladipo a couple of notes
|
Thanks for your feedback @zenweasel . I've resolved the first two points you raised. I will add you as a reviewer (and thus make you get a notification) as soon as I finish some checks today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, verified fixed
@foladipo Not sure how this is happening since you didn't touch these files but we have 3 files that are failing ESLint. Let's fix those now while we catch them. |
This PR resolves #2620. The said issue was a bug report for an error that occurred whenever a user tried to archive a product. These trials consequently failed. And it was all due to the wrong use of a certain function's parameter.
Testing steps
Basic Reaction Product
) or another product (if you've added any).