Fix for variant option not updating when edited #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foladipo
changed the title
brent-hoover
requested changes
Aug 16, 2017
| @@ -49,9 +49,11 @@ Template.childVariantForm.helpers({ | |||
| Icon() { | |||
| return Components.Icon; | |||
| }, | |||
|
|
|||
There was a problem hiding this comment.
Can we not add in these line breaks for no reason?
|
@foladipo So this is an example of where we want to make sure and loop back on these PR's quickly. Let's try to make the one change I requested and get this merged? You should almost always prioritize dealing with PR feedback over almost anything. |
|
So sorry for the delay @zenweasel . I've now cleaned out the unnecessary line breaks and pushed the update. |
brent-hoover
approved these changes
Aug 18, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2582
This PR fixes a bug with creating options for product variants. Previously, editing an option did not update parts of the UI. This PR fixes that bug.
Testing steps
optionorpriceform field. Immediately you hitEnter, click elsewhere on the page or hitTab, the UI is updated with the text or price you added to the form field.