-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update verbiage for better Backorder display / understanding #2830
Conversation
This makes sense to me. |
Maybe instead of reversing the value, we can ensure that when the switch is Not sure re-reversing the value the switch provided, which was already reversed, makes this less confusing. |
@mikemurray that's how it was intended to work originally, but would involve changing the language back to something similar to "Deny when out of stock" as is still listed as the label for the schema. To me this is a copy/ux issue and not a schema or engineering one. The schema copies Shopify (and other platforms) terminology of having an option to Deny ordering/adding-to-cart of products that are out-of-stock. Exactly how we communicate that to users is more of a @aaronjudd / @sophiehe question. |
@spencern makes sense. 👍 |
is the same as `handleCheckboxChange`. | ||
*/ | ||
|
||
const reverseValue = !value; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicky but I'd prefer inverseValue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this as it fixes an issue and isn't changing the verbiage in this PR, just fixing what currently exists.
If necessary we can open another issue to discuss the verbiage around this functionality.
Resolves #2828
The terminology used on the PDP in relation to Backorders / inventory is confusing, seemingly displaying the opposite of what is actually happening.
This update simply reverses the display of a toggle switch to show the opposite boolean value, which helps decipher what's actually going on for the end-user.