Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow settings of "parcel" object from PDP Options and store on cart #2992

Merged
merged 5 commits into from
Oct 3, 2017
Merged

Allow settings of "parcel" object from PDP Options and store on cart #2992

merged 5 commits into from
Oct 3, 2017

Conversation

brent-hoover
Copy link
Collaborator

@brent-hoover brent-hoover commented Oct 2, 2017 •
edited
Loading

This closes #2958

I debated just moving these dimensions from the variant to the option but tried to make it backwards compatible.

To Test

Steps to Reproduce the Behavior

  1. Login as administrator
  2. Enable Shippo and enable carriers
  3. Create a product (don't use the built-in product) and set weight and dimensions
  4. Add only the newly created product to cart
  5. Attempt to checkout
  6. Observe that shipping methods are displayed

@brent-hoover brent-hoover changed the title Allow settings of "parcel" object from PDP Options and store on cart [WIP] Allow settings of "parcel" object from PDP Options and store on cart Oct 2, 2017
@brent-hoover brent-hoover changed the title [WIP] Allow settings of "parcel" object from PDP Options and store on cart Allow settings of "parcel" object from PDP Options and store on cart Oct 2, 2017
@spencern
Copy link
Contributor

spencern commented Oct 2, 2017

@rymorgan this gets into your territory a little bit as well.

@spencern spencern mentioned this pull request Oct 3, 2017
Closed
@brent-hoover brent-hoover removed the request for review from kieckhafer October 3, 2017 07:24
spencern
spencern approved these changes Oct 3, 2017
View reviewed changes
Copy link
Contributor

@spencern spencern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution to this problem. We'll need to add "default parcel" size settings to the shipping dashboard.

@spencern spencern merged commit 8a03b25 into marketplace Oct 3, 2017
@spencern spencern deleted the brent-fix-issue-2958 branch October 3, 2017 21:26
This was referenced Oct 3, 2017
Closed
Closed
@spencern spencern mentioned this pull request Oct 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencern spencern spencern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brent-hoover @spencern