-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
open actionView to appropriate location when clicking on product text fields #3015
Conversation
@kieckhafer Did you mean to do this to |
@zenweasel did not, good catch, thanks |
@@ -465,6 +465,7 @@ class ActionView extends Component { | |||
} | |||
|
|||
render() { | |||
console.log("actionView", this.props); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably want to remove this?
@@ -43,6 +45,14 @@ class ProductField extends Component { | |||
} | |||
} | |||
|
|||
handleFocus = (event) => { | |||
// Open actionView, if it's not open already | |||
console.log("this input", this._input); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
going to remove these for you as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice,
only issue one thing I've found:
Going from editing a variant to clicking the title of the product closes the variant section, but does not open the product panel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs look good 👍
@kieckhafer This second one is what I described above. When clicking the title while a variant edit panel is open, it does not open the product edit action view. |
@spencern issue 2 is fixed. Issue 1 still trying to figure out what triggers that closing. |
@spencern The expanding issue should be resolved now. |
Works as expected |
Fixes #2999
Opens PDP to Product Settings panel when loading the PDP for the first time, or clicking on a field taht is in the Product Settings section.