Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open actionView to appropriate location when clicking on product text fields #3015

Merged
merged 14 commits into from
Oct 7, 2017

Conversation

kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Oct 3, 2017

Fixes #2999

Opens PDP to Product Settings panel when loading the PDP for the first time, or clicking on a field taht is in the Product Settings section.

  • As an admin, double click on a product from the product grid.
  • See that the Product Settings panel is the open panel in the action view when landing on the PDP

  • As an admin, click the social settings edit button, so that the social section is open in the action view.
  • Click the title / subtitle field on the PDP
  • See that the correct section of the action view opens

@brent-hoover
Copy link
Collaborator

@kieckhafer Did you mean to do this to master?

@kieckhafer kieckhafer changed the base branch from master to marketplace October 3, 2017 21:47
@kieckhafer
Copy link
Member Author

@zenweasel did not, good catch, thanks

@kieckhafer kieckhafer changed the title [WIP] open actionView to appropriate location when clicking on product text fields open actionView to appropriate location when clicking on product text fields Oct 5, 2017
@@ -465,6 +465,7 @@ class ActionView extends Component {
}

render() {
console.log("actionView", this.props);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want to remove this?

@@ -43,6 +45,14 @@ class ProductField extends Component {
}
}

handleFocus = (event) => {
// Open actionView, if it's not open already
console.log("this input", this._input);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to remove these for you as well.

Copy link
Contributor

@spencern spencern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice,
only issue one thing I've found:
Going from editing a variant to clicking the title of the product closes the variant section, but does not open the product panel.

@spencern spencern changed the base branch from marketplace to release-1.5.0 October 6, 2017 15:53
Copy link
Contributor

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs look good 👍

@spencern
Copy link
Contributor

spencern commented Oct 6, 2017

@kieckhafer
Here are the two problems that I'm still seeing. This first one is a little inconsistent, but by double-clicking the product in the product grid, I can reproduce it most of the time. I'm not sure if it's a double-click failure or if something is taking over once I land on the PDP. What happens is when I land on the PDP, the correct product panel is open in the action view, but then it immediately closes.

This second one is what I described above. When clicking the title while a variant edit panel is open, it does not open the product edit action view.

@kieckhafer
Copy link
Member Author

@spencern issue 2 is fixed. Issue 1 still trying to figure out what triggers that closing.

@mikemurray
Copy link
Member

@spencern The expanding issue should be resolved now.

@spencern
Copy link
Contributor

spencern commented Oct 6, 2017

Works as expected

@spencern spencern merged commit 3912df7 into release-1.5.0 Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants