Fixed browser Back Button anomaly on PDP #3032
Conversation
| @@ -272,7 +272,7 @@ function composer(props, onData) { | |||
| const tagSub = Meteor.subscribe("Tags"); | |||
| const shopIdOrSlug = Reaction.Router.getParam("shopSlug"); | |||
| const productId = Reaction.Router.getParam("handle"); | |||
| const variantId = Reaction.Router.getParam("variantId"); | |||
| const variantId = ReactionProduct.selectedVariant()._id; | |||
There was a problem hiding this comment.
You could probably use ReactonProduct.selectedVariantId() instead.
There was a problem hiding this comment.
Thanks I just refactored it to selectedVariantId()
aanchirinah
force-pushed
the
audax-fix-issue-2660
branch
from
c041aae
to
0446f06
Compare
| @@ -19,7 +19,7 @@ function composer(props, onData) { | |||
| } | |||
|
|
|||
| if (shop && Array.isArray(shop.brandAssets)) { | |||
| const brandAsset = _.find(this.getShop().brandAssets, (asset) => asset.type === "navbarBrandImage"); | |||
There was a problem hiding this comment.
Is there a reason this change was added to this PR? If this is fixing an another issue it should be explicitly called out in the comments. Generally we should keep bugfix PR's pretty focused on fixing just the one issue.
There was a problem hiding this comment.
I got that change in brandAssets when I pulled recent changes from marketplace branch.
There was a problem hiding this comment.
how would that be possible? If you are up to date with marketplace then why would you have that change? Did you merge a conflict?
There was a problem hiding this comment.
I made a typographical error in my commit message so I reset my HEAD and unknowingly unstaged the change that was made to the brandAssets.
| @@ -19,7 +19,7 @@ function composer(props, onData) { | |||
| } | |||
|
|
|||
| if (shop && Array.isArray(shop.brandAssets)) { | |||
| const brandAsset = _.find(this.getShop().brandAssets, (asset) => asset.type === "navbarBrandImage"); | |||
| const brandAsset = _.find(shop.brandAssets, (asset) => asset.type === "navbarBrandImage"); | |||
There was a problem hiding this comment.
This is identical to the line in the current marketplace branch so I'm confused as to why it's showing this as a change, but it appears to be correct.
https://github.com/reactioncommerce/reaction/blob/marketplace/imports/plugins/core/ui-navbar/client/containers/navbar.js#L22
There was a problem hiding this comment.
I pulled the latest changes from marketplace , I made a typographical error in my commit message so I reset my HEAD and unknowingly unstaged the change that was made to the brandAssets.
Resolves #2660 ,
So there was a
Router.gosnippet invaraintList.jsthat was changing the URL when a variant is selected, so based on @mikemurray comment on how to fix the issue , I refactored the composer object (inproductDetail.js) to get variantId by usingReactionProduct.selectedVariant()._idrather than fetching it as a param from the URL.HOW TO TEST