Adds the ability to set shops to active / disabled #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machikoyasuda
approved these changes
Oct 6, 2017
There was a problem hiding this comment.
comments + jsdocs 👍
added reactioncommerce/reaction-docs#295
spencern
reviewed
Oct 6, 2017
| return { | ||
| Header: <Components.Translation i18nKey={`marketplaceShops.headers.${field}`} defaultValue={field} />, | ||
| accessor: field, | ||
| Cell: (data) => ( // eslint-disable-line |
There was a problem hiding this comment.
What's disabled here? It's a little more clear if we can use eslint-disable-line rule-name so future us/others can understand why we disabled and what for
There was a problem hiding this comment.
I'm actually not seeing any lint errors when removing this, so perhaps not needed?
There was a problem hiding this comment.
It's usually a react issue of defining more than one component per file.
spencern
reviewed
Oct 6, 2017
| check(workflowStatus, String); | ||
|
|
||
| if (shopId === Reaction.getPrimaryShopId()) { | ||
| throw new Meteor.Error(403, "Cannot change shop status"); |
There was a problem hiding this comment.
We're no longer using error codes here, this should be `Meteor.Error("access-denied", "Cannot change shop status");
|
@spencern ninja fixed it before I could 👍 |
spencern
approved these changes
Oct 6, 2017
This was referenced Oct 6, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes items 2 and 3 for #2864
This PR adds a simple table to set marketplace shops to
active/disabledAs a customer
If a shop is disabled, its products are de-listed from the product grid if using the default
Productspublication.As an admin
You can see all shops and all products from all shops at the moment.
This is the start of a full-on marketplace shop management tools.