-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent language in cart or orders #3169
Consistent language in cart or orders #3169
Conversation
…he Order Completed Page and Process Order Action View
Thank you for using sentence case <3 |
@rymorgan These changes seem fine but does somebody need to verify that we got all of them? |
@zenweasel What's the best way of doing that? Can't we search the code to find where we are using this language (Quantity Total)? I can comb through the app and try to find all the places but that seems like I'll probably miss something. |
@rymorgan all labels are in i18n (en.json) files... |
@codejockie did you double check the i18n (en.json) files for any more instances of 'Quantity total'? Please, do that and let me know all/any places that it's been changed so I can QA. |
@rymorgan okay, will do that and get back to you. |
@rymorgan I did a search for "Quantity Total" in this PR, and I came across none as I have replaced the instances where they once existed with the right words |
@codejockie Great, sounds good. Should be good to go then. |
@codejockie You have a conflict you need to resolve, but otherwise good to go. |
@zenweasel conflict resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to go.
After removing unused prop in f959388 this now passes eslint. |
…guage-in-cart-or-orders-2798 Consistent language in cart or orders
Resolves #2798
How to Test