Refactor 3570 willopez fix eslint errors #3604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemurray
reviewed
Jan 29, 2018
| @@ -22,7 +22,7 @@ Template.React.onRendered(function () { | |||
| const comp = data && data.component; | |||
| if (!comp) { | |||
| throw new Error( | |||
| "In template " + parentTemplate + ", call to `{{> React ... }}` missing " + | |||
| `In template ${parentTemplate}, call to \`{{> React ... }}\` missing ` + | |||
| "`component` argument."); | |||
There was a problem hiding this comment.
Is this line supposed to be part of the top template?
| throw new Meteor.Error(`ACK ${ | ||
| parsedResponse.ACK}: ${ | ||
| parsedResponse.L_LONGMESSAGE0}:${ | ||
| parsedResponse.L_ERRORCODE0}`); |
There was a problem hiding this comment.
These look kinda strange. Should the opening tag${ not be on the same line as the matching closing }? Or just be a single line like the other instances I see.
mikemurray
approved these changes
Jan 30, 2018
…0-willopez-fix-eslint-errors # Conflicts: # server/api/core/ui.js
…0-willopez-fix-eslint-errors # Conflicts: # .eslintrc # imports/plugins/core/accounts/client/components/groupsTableCell.js # imports/plugins/core/accounts/client/templates/members/member.js # imports/plugins/included/payments-braintree/client/checkout/braintree.js # imports/plugins/included/payments-paypal/server/methods/express.js # imports/plugins/included/product-variant/containers/gridItemControlsContainer.js # server/api/core/import.js # server/methods/catalog.js # server/methods/core/cart.js
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes linting errors caused by enabling several linting rules.
Testing