Refactor 2468 nnnnat remove theme editor #3614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
January 30, 2018 14:26
…om imports/plugins/core/ui/client/index.js
…ports/plugins/core/ui/register.js
… imports/plugins/core/layout/server/index.js to not import the old theme file
….js to not import/use the ui.js package
mikemurray
approved these changes
Jan 31, 2018
|
This is so exciting:
|
Merged
This was referenced Feb 14, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #2468
Summary
Removed theme editor code from Reaction Commerce, removed any imports of the old theme editor code, updated package.json to remove unneeded theme editor dependencies.
reaction testpassedTesting